Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 286 #287

Merged
merged 8 commits into from
Nov 16, 2023
Merged

fix 286 #287

merged 8 commits into from
Nov 16, 2023

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Nov 16, 2023

Pull Request Checklist:

What kind of change does this PR introduce?

  • add warning for the matching of hist and fut without activity

Does this PR introduce a breaking change?

Other information:

@juliettelavoie juliettelavoie changed the title fix 386 fix 286 Nov 16, 2023
@Zeitsperre
Copy link
Contributor

There's an issue with the current conda version. Pushing a fix soon.

Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems enough for the user to avoid the issue!

xscen/extract.py Outdated Show resolved Hide resolved
Copy link
Contributor

@coxipi coxipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's clear, thanks

@juliettelavoie juliettelavoie merged commit f765093 into main Nov 16, 2023
9 checks passed
@juliettelavoie juliettelavoie deleted the fix-286 branch November 16, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matching historical and sspXYZ using df with incomplete columns make the historical period disappear
4 participants